Initial setup for migrating to declarative mapping #12042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Create sqlalchemy.orm.registry 2. Use registry.metadata for both model/__init__ and mapping.py Why: 1) Direct usage of mapper() function is deprecated 2) Mapper assumes a registry object is present 3) Both declarative and imperative (aka classical) mapping use a registry object in the background. Access to this object is also necessary to INCREMENTALLY migrate Galaxy to declarative mapping (as opposed to moving the entire model and eliminating mapping.py in one step). https://docs.sqlalchemy.org/en/14/orm/mapping_styles.html#imperative-a-k-a-classical-mappings
jdavcs
added
kind/enhancement
area/database
2 tasks
mvdbeek
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you do?
This removes a deprecated SQLAlchemy function and sets up the necessary infrastructure to incrementally migrate Galaxy to declarative mapping.
model/__init__.pyandmapping.pyWhy:
registry object in the background. Access to this object is also
necessary to incrementally migrate Galaxy to declarative mapping (as
opposed to moving the entire model and eliminating mapping.py in one
step).
https://docs.sqlalchemy.org/en/14/orm/mapping_styles.html#imperative-a-k-a-classical-mappings
Why did you make this change?
See #10901
How to test the changes?
This is a refactoring of components with existing test coverage.
License